[ISSUE #10859] Fix exhausted tiered index write result - #11185
Open
beautyarbutin wants to merge 1 commit into
Open
beautyarbutin wants to merge 1 commit into
beautyarbutin wants to merge 1 commit into
Conversation
RockteMQ-AI
reviewed
Sep 21, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fixes a clear bug where IndexStoreService.putKey returned SUCCESS after all three write attempts failed. The fix correctly propagates the last failure result (AppendResult.UNKNOWN_ERROR or FILE_FULL) back to the caller.
Findings
- [Critical] This was a data integrity bug — returning SUCCESS on failure could cause the caller to believe the index was written when it was not. Good catch.
- [Info] The test
putKeyReturnsLastFailureAfterRetriesTestis well-structured: uses Mockito to simulate sequential failures and verifies both the return value and the retry count (3 putKey calls, 2 createNewIndexFile calls).
Overall
Clean, minimal fix with proper test coverage. LGTM.
Automated review by RockteMQ-AI
RockteMQ-AI
approved these changes
Sep 21, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
New commits pushed since last review. The changes look good — addressing the previous feedback. LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
IndexStoreService.putKeyreturnedSUCCESSafter all three index write attempts failed. This change retains the result of each attempt and returns the final failure once retries are exhausted, while preserving the existing success path andFILE_FULLfile rotation behavior.The regression test exercises
FILE_FULL,FILE_FULL, andUNKNOWN_ERROR, then verifies that the final error is propagated after three attempts and that file rotation occurs only for the twoFILE_FULLresults.How Did You Test This Change?
UNKNOWN_ERRORbut receivedSUCCESS.mvn -pl tieredstore -am -DskipITs -Dtest=IndexStoreServiceTest -Dsurefire.failIfNoSpecifiedTests=false test.